Convert some "check" style transforms into verifications #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this attribute really gets used past the optimization phase, but the fact it wasn't being updated tripped up a test I was working on, so figured it doesn't hurt to keep it consistent.
bhearsum
approved these changes
Oct 30, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
Nice! I imagine this probably isn't a huge perf win in the decision task for Gecko, but it's probably something, and it is certainly a correctness win.
(I imagine there's probably similar things we should do in Gecko; can we get something on file for that if so?)
jcristau
added a commit
to jcristau/fxci-config
that referenced
this pull request
Dec 11, 2025
…failures The task command mangling we're doing means the verification doesn't realize these tasks are actually using run-task. This code wasn't running here until taskcluster/taskgraph#849 since we're not using the task transforms for integration tests, but now that it's a verification it's looking at our tasks and not liking them.
jcristau
added a commit
to jcristau/fxci-config
that referenced
this pull request
Dec 11, 2025
…failures The task command mangling we're doing means the verification doesn't realize these tasks are actually using run-task. This code wasn't running here until taskcluster/taskgraph#849 since we're not using the task transforms for integration tests, but now that it's a verification it's looking at our tasks and not liking them.
jcristau
added a commit
to jcristau/fxci-config
that referenced
this pull request
Dec 11, 2025
…failures The task command mangling we're doing means the verification doesn't realize these tasks are actually using run-task. This code wasn't running here until taskcluster/taskgraph#849 since we're not using the task transforms for integration tests, but now that it's a verification it's looking at our tasks and not liking them.
jcristau
added a commit
to mozilla-releng/fxci-config
that referenced
this pull request
Dec 16, 2025
…failures The task command mangling we're doing means the verification doesn't realize these tasks are actually using run-task. This code wasn't running here until taskcluster/taskgraph#849 since we're not using the task transforms for integration tests, but now that it's a verification it's looking at our tasks and not liking them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.