fix: block tc proxy in script_url #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible this is a terrible idea, but when I tried to run [a generic-worker task with run-task](https://firefox-ci-tc.services.mozilla.com/tasks/CyQ3aIZyRE6NdWBwyeif6Q) and the proxy enabled, it failed to download `run-task`: ``` [taskcluster 2025-10-30T01:05:04.835Z] [mounts] Downloading url http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task to D:\downloads\ZenjqqtWT76WhzgTtovcNQ [taskcluster:warn 2025-10-30T01:05:07.534Z] [mounts] Download of url http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task failed on this attempt: Get "http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task": dial tcp: lookup taskcluster: no such host ``` Opening this is a starting point, because [it works](https://firefox-ci-tc.services.mozilla.com/tasks/EFT5KvV3QVS7fzowTAyfVQ), and it's [similar to what we do in Gecko](https://searchfox.org/firefox-main/rev/75f89f7dee3f30c371af717da54ba8bbf046e5fd/taskcluster/gecko_taskgraph/transforms/job/run_task.py#119); but I'm not tied to it.
Eijebong
approved these changes
Oct 30, 2025
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
This restores the behavior pre taskcluster client usage. The comment is correct, it was assuming that the cluster would allow public access to artifacts:
- # use_proxy = False to avoid having all generic-workers turn on proxy
# Assumes the cluster allows anonymous downloads of public artifacts
- tc_url = taskcluster.get_root_url(False)
+ tc_url = taskcluster.get_root_url()(get_root_url went from use_proxy to block_blocky=False)
abhishekmadan30
pushed a commit
to abhishekmadan30/taskgraph
that referenced
this pull request
Dec 24, 2025
It's possible this is a terrible idea, but when I tried to run [a generic-worker task with run-task](https://firefox-ci-tc.services.mozilla.com/tasks/CyQ3aIZyRE6NdWBwyeif6Q) and the proxy enabled, it failed to download `run-task`: ``` [taskcluster 2025-10-30T01:05:04.835Z] [mounts] Downloading url http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task to D:\downloads\ZenjqqtWT76WhzgTtovcNQ [taskcluster:warn 2025-10-30T01:05:07.534Z] [mounts] Download of url http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task failed on this attempt: Get "http://taskcluster/api/queue/v1/task/YpWux6HWR6ux40YwCpi5fg/artifacts/public/run-task": dial tcp: lookup taskcluster: no such host ``` Opening this is a starting point, because [it works](https://firefox-ci-tc.services.mozilla.com/tasks/EFT5KvV3QVS7fzowTAyfVQ), and it's [similar to what we do in Gecko](https://searchfox.org/firefox-main/rev/75f89f7dee3f30c371af717da54ba8bbf046e5fd/taskcluster/gecko_taskgraph/transforms/job/run_task.py#119); but I'm not tied to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible this is a terrible idea, but when I tried to run a generic-worker task with run-task and the proxy enabled, it failed to download
run-task:Opening this is a starting point, because it works, and it's similar to what we do in Gecko; but I'm not tied to it.