fix: get_taskcluster_client should respect PRODUCTION_TASKCLUSTER_ROOT_URL #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Oct 24, 2025
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
LGTM. I personally don't mind either but in case you'd prefer it, looks like optionsFromEnvironment has a defaults parameter that you could set to that.
def optionsFromEnvironment(defaults=None):
options = defaults or {}
Contributor
Author
|
Thanks, updated. I figure we should also have tests for get_taskcluster_client... |
jcristau
force-pushed
the
tc-client-root-url
branch
5 times, most recently
from
91702f1 to
2d4d8eb
Compare
Eijebong
approved these changes
Oct 24, 2025
…T_URL If no root url is set in the environment but PRODUCTION_TASKCLUSTER_ROOT_URL is set, we should use that. See https://bugzilla.mozilla.org/show_bug.cgi?id=1996183
jcristau
force-pushed
the
tc-client-root-url
branch
from
2d4d8eb to
5dd3a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no root url is set in the environment but
PRODUCTION_TASKCLUSTER_ROOT_URL is set, we should use that.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1996183