Skip to content

Conversation

@ahal
Copy link
Collaborator

@ahal ahal commented Oct 17, 2025

No description provided.

@ahal ahal self-assigned this Oct 17, 2025
@ahal ahal force-pushed the ahal/push-vymklnmuovus branch 3 times, most recently from 61f5244 to 26bb12b Compare October 17, 2025 20:10
@ahal ahal marked this pull request as ready for review October 17, 2025 20:51
@ahal ahal requested a review from a team as a code owner October 17, 2025 20:51
@ahal ahal requested a review from hneiva October 17, 2025 20:51
@jcristau
Copy link
Contributor

Do you know how we end up with forkserver here?

mp_context=multiprocessing.get_context("fork")
was meant to avoid that.

@ahal
Copy link
Collaborator Author

ahal commented Oct 20, 2025

Do you know how we end up with forkserver here?

mp_context=multiprocessing.get_context("fork")

was meant to avoid that.

Ah, I didn't realize we were doing that. This is the parallelization that happens when you pass in multiple parameters files, so different context. Do you think we should avoid forkserver there as well? I guess we're currently using fork based subprocesses within forkserver based subprocesses on Python 3.14

@jcristau
Copy link
Contributor

This is the parallelization that happens when you pass in multiple parameters files, so different context

Oh, right, of course.

Do you think we should avoid forkserver there as well?

Hmm, probably not. What you're doing here probably makes more sense than sticking with fork in that case.

ahal added 3 commits October 20, 2025 09:29
Python 3.14 switched multiprocessing to use the "forkserver" start
method. This means the forked subprocess don't inherit the parent
process' memory and the monkeypatched functions (via the `run_taskgraph`
fixture) were no longer applied.

This works around the issue by actually creating bad parameter files to
avoid monkeypatching.
@ahal ahal force-pushed the ahal/push-vymklnmuovus branch from 26bb12b to 85d5953 Compare October 20, 2025 13:29
@ahal ahal enabled auto-merge (rebase) October 20, 2025 13:30
@ahal ahal merged commit 06698c4 into taskcluster:main Oct 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants