Skip to content

Make sure every node is in the values returned from links_and_reverse_links_dict #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eijebong merged 1 commit into from
Oct 17, 2025
Merged

Make sure every node is in the values returned from links_and_reverse_links_dict #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/taskgraph/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _visit(self, reverse):
dependencies = reverse_links if reverse else forward_links
dependents = forward_links if reverse else reverse_links

indegree = {node: len(dependencies.get(node, ())) for node in self.nodes}
indegree = {node: len(dependencies[node]) for node in self.nodes}

queue = collections.deque(
node for node, degree in indegree.items() if degree == 0
Expand All @@ -93,7 +93,7 @@ def _visit(self, reverse):
node = queue.popleft()
yield node

for dependent in dependents.get(node, ()):
for dependent in dependents[node]:
indegree[dependent] -= 1
if indegree[dependent] == 0:
queue.append(dependent)
Expand Down Expand Up @@ -128,8 +128,8 @@ def links_and_reverse_links_dict(self):
`reverse_links_dict` counterparts to avoid consumers modifying the
cached value by mistake.
"""
forward = collections.defaultdict(set)
reverse = collections.defaultdict(set)
forward = {node: set() for node in self.nodes}
reverse = {node: set() for node in self.nodes}
for left, right, _ in self.edges:
forward[left].add(right)
reverse[right].add(left)
Expand Down
Loading