Make sure that cached values from links_and_reverse_links_dict are not mutable inside #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t mutable inside Yay python, it's great... In 20b45ba we made sure that we'd return read only dicts from this function since it's caching the result, but we kinda forgot that the value was a set and thus was still mutable... This commits freezes said sets so now those objects should be properly read only...
Eijebong
force-pushed
the
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
branch
from
4d1f2d3 to
3f077bb
Compare
jcristau
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay python, it's great... In 20b45ba we made sure that we'd return read only dicts from this function since it's caching the result, but we kinda forgot that the value was a set and thus was still mutable... This commits freezes said sets so now those objects should be properly read only...