Make sure we return read only dicts from links_and_reverse_links_dict
#825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we cache the return value, we don't want to be returning objects with inner mutability as a consumer modifying those would end up modifying the cached value, impacting all future accesses.
jcristau
approved these changes
Oct 17, 2025
jcristau
requested changes
Oct 17, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
On second thought.. the values in these ReadOnlyDicts are still mutable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we cache the return value, we don't want to be returning objects with inner mutability as a consumer modifying those would end up modifying the cached value, impacting all future accesses.