Use links_and_reverse_links_dict in replace_tasks
#824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
force-pushed
the
dont-build-links-in-two-times
branch
from
57263ee to
164605f
Compare
jcristau
approved these changes
Oct 17, 2025
jcristau
requested changes
Oct 17, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Actually, with the ReadOnlyDict changes we need to check all accesses probably.
In b713497 we added a function to get both `links_dict` and `reverse_links_dict` in one go, avoiding iterating over the graph twice to build those. That function also benefits from being cached. I'm not expecting a big change in performance here but we might as well.
Eijebong
force-pushed
the
dont-build-links-in-two-times
branch
from
164605f to
b2b0efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b713497 we added a function to get both
links_dictandreverse_links_dictin one go, avoiding iterating over the graph twice to build those. That function also benefits from being cached. I'm not expecting a big change in performance here but we might as well.