feat: create the perfherder-data.json for fetch-content task (bug-1992052) #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
approved these changes
Oct 2, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
I'm not super keen on adding more Mozilla-specific things to this, but seeing as this is really just doing what the print is currently doing, this seems like a sidestep rather than moving backwards.
| } | ||
| ], | ||
| } | ||
| print("PERFHERDER_DATA: {}".format(json.dumps(perfherder_data)), file=sys.stderr) |
Contributor
There was a problem hiding this comment.
Should this print be removed now that we're spitting out a proper artifact?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review :) We’ll keep this log for now as we transition from log output to the JSON artifact step by step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, performance data is logged only as
PERFHERDER_DATA:.This PR creates a
perfherder-data-fetch-content.jsonartifact in the production environment(not local) for downstream tools.Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1992052
I ran a CI test [0].
When testing with the
mach try fuzzycommand, I wrote the code to mozilla-central[1] to check the CI result.[0]
https://firefoxci.taskcluster-artifacts.net/VjtXAyawTb257WRd8FE8lw/0/public/build/perfherder-data-fetch-content.json
https://treeherder.mozilla.org/jobs?repo=try&revision=9d2a399b35c3e9e9f8f98a8668b882ff76060f53&selectedTaskRun=VjtXAyawTb257WRd8FE8lw.0
[1]
https://searchfox.org/firefox-main/source/third_party/python/taskcluster_taskgraph/taskgraph/run-task/fetch-content#954