Add ability to use custom images in taskgraph load-task
#768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-nmnxwlyzwlvv
branch
2 times, most recently
from
b55a58a to
295565f
Compare
jcristau
reviewed
Sep 11, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Looks like a nice improvement, I just have a few questions/comments.
ahal
force-pushed
the
ahal/push-nmnxwlyzwlvv
branch
4 times, most recently
from
b581a77 to
b3cd974
Compare
jcristau
reviewed
Sep 18, 2025
ahal
force-pushed
the
ahal/push-nmnxwlyzwlvv
branch
3 times, most recently
from
a811b00 to
fd0cb58
Compare
This implements `taskgraph load-task --image <image>`, where <image> can be one of: * task-id=<task id> - Downloads image.tar from specified task id * image=<image> - Downloads image.tar from specified index path * <image name> - Builds image that lives under `taskcluster/docker/<image name>` * <image reference> - Uses specified image from a registry
ahal
force-pushed
the
ahal/push-nmnxwlyzwlvv
branch
from
fd0cb58 to
a67d335
Compare
jcristau
approved these changes
Sep 22, 2025
Comment on lines
+689
to
+691
| help="Use a custom image instead of the task's image. Can be the name of " | ||
| "an image under `taskcluster/docker`, `task-id=<task id>`, or " | ||
| "`index=<index path>`.", |
Contributor
There was a problem hiding this comment.
or the name of an image to pull from a registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it really nice to iterate on a docker image and test it against a live task, by using e.g:
This will re-build the
taskcluster/docker/pythonimage, launch it in a container, and load<task-id>into it.