Various taskgraph load-task fixes
#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were checking whether the worker-implementation was docker-worker by looking at the task tags. But many projects are missing this tag, and especially Decision tasks don't tend to have it. Instead, check if the `payload.image` key is defined.
ahal
force-pushed
the
ahal/push-pnyqlyvxwoxv
branch
2 times, most recently
from
6936dfe to
d16425e
Compare
bhearsum
approved these changes
Sep 5, 2025
| impl := task_def.get("tags", {}).get("worker-implementation") | ||
| ) != "docker-worker": | ||
| print(f"Tasks with worker-implementation '{impl}' are not supported!") | ||
| if "payload" not in task_def or not (image := task_def["payload"].get("image")): |
Contributor
There was a problem hiding this comment.
TIL that walrus assignments in a conditional block are valid in the outer scope. This is fine...but I admit I was bit confused about where the image further down was coming from at first.
Collaborator
Author
There was a problem hiding this comment.
Yeah... It threw me off initially as well. Originally I didn't have the payload not in task_def fix and it looked a bit less confusing.
I can change it if you like, or I can leave it and force everyone to get used to it 😈
Contributor
There was a problem hiding this comment.
fwiw I'd rather we didn't have assignments in the middle of complex conditions
ahal
force-pushed
the
ahal/push-pnyqlyvxwoxv
branch
from
d16425e to
1c9cbd5
Compare
run-task expects the worker to mount a volume at each path passed in here. Let's avoid needing the user of `taskgraph load-task` needing to do the same.
ahal
force-pushed
the
ahal/push-pnyqlyvxwoxv
branch
from
1c9cbd5 to
ffb3ed9
Compare
jcristau
reviewed
Sep 8, 2025
Comment on lines
+330
to
+331
| # run-task expects the worker to mount a volume for each path defined in | ||
| # TASKCLUSTER_CACHES, delete them to avoid needing to do the same. |
Contributor
There was a problem hiding this comment.
Couldn't we just as easily mount a volume there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.