fix: make task_context transforms really work without a task-context #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Sep 4, 2025
jcristau
force-pushed
the
task-context-fixup
branch
from
31bca87 to
5b6a713
Compare
Contributor
Author
|
Updated to add a test. |
jcristau
force-pushed
the
task-context-fixup
branch
from
5b6a713 to
ff9f652
Compare
It's not enough to make it optional in the schema, the actual code also has to deal with its absence. Thanks @ErichDonGubler!
jcristau
force-pushed
the
task-context-fixup
branch
from
ff9f652 to
9724ebf
Compare
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 4, 2025
…ewers,jcristau This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 4, 2025
This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Sep 8, 2025
…ewers,jcristau This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 8, 2025
…ewers,jcristau This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711 UltraBlame original commit: 1df33d75edd6b176913b230d7510c338f4ccca37
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 8, 2025
…ewers,jcristau This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711 UltraBlame original commit: 1df33d75edd6b176913b230d7510c338f4ccca37
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 8, 2025
…ewers,jcristau This picks up taskcluster/taskgraph#761, which finishes making `task-context` optional. Differential Revision: https://phabricator.services.mozilla.com/D263711 UltraBlame original commit: 1df33d75edd6b176913b230d7510c338f4ccca37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not enough to make it optional in the schema, the actual code also has to deal with its absence.
Thanks @ErichDonGubler!