Fix some more type checking errors #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Small continuation of my last PR last year, linked in description 😅. |
ahal
approved these changes
Aug 25, 2025
Collaborator
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks very much for the contribution!
Collaborator
|
Ah, unfortunately there are some merge conflicts so we can't rebase this automatically. Could you pull in the latest |
YaySushi
force-pushed
the
fix-more-type-checking-errors
branch
from
607c3b3 to
c126d16
Compare
Contributor
Author
|
Done! Hopefully I did that right. |
Collaborator
|
Looks good, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (another very small) part of issue #476. My last PR was: #567
Notes:
pytest reported the same stats before and after my changes (looks like orjson gives a warning)
Some removals of # type: ignore did not result in an error from pyright (some status code comparisons)