Fix parameter order for build_image/build_context in main #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from d2dee6a which added the graph config arg but then got the order wrong in these calls which lead to `TypeError: unhashable type: '_Environ'` in image_path when calling `taskgraph build-image` ``` Traceback (most recent call last): File "src/taskgraph/main.py", line 1020, in main return args.command(vars(args)) ~~~~~~~~~~~~^^^^^^^^^^^^ File "src/taskgraph/main.py", line 593, in build_image build_image(args["image_name"], args["tag"], os.environ, graph_config) ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "src/taskgraph/docker.py", line 122, in build_image image_dir = docker.image_path(name, graph_config) File "src/taskgraph/util/docker.py", line 225, in image_path paths = image_paths(graph_config) TypeError: unhashable type: '_Environ' ```
jcristau
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from d2dee6a which added the graph config arg but then got the order wrong in these calls which lead to
TypeError: unhashable type: '_Environ'in image_path when callingtaskgraph build-image