fix: fallback to guessing repo root in config.py #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made the repo root detection smarter by using util/vcs.py to search for the `.git` directory. However, this broke a MacOS build task in Gecko CI because no `.git` directory exists. I'm not entirely sure why that happens, as the Taskgraph command still needs to run from the repo root. Ay any rate, this patch re-adds the old logic as a fallback in the event util/vcs.py wasn't able to detect the repo.
ahal
force-pushed
the
ahal/push-puqsuvllpmuz
branch
from
7da3d22 to
a8ff729
Compare
bhearsum
approved these changes
Aug 13, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
This seems like a fine workaround for now...let's make sure we have something on file for investigation later though, considering how annoying it was to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made the repo root detection smarter by using util/vcs.py to search for the
.gitdirectory. However, this broke a MacOS build task in Gecko CI because no.gitdirectory exists. I'm not entirely sure why that happens, as the Taskgraph command still needs to run from the repo root.At any rate, this patch re-adds the old logic as a fallback in the event util/vcs.py wasn't able to detect the repo.