feat: add a commandline flag to disable verifications #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hneiva
reviewed
Jul 31, 2025
| if self._enable_verifications: | ||
| verifications(name, *args, **kwargs) | ||
| if args: | ||
| return name, args[0] |
Contributor
There was a problem hiding this comment.
Why does it return anything?
Collaborator
Author
There was a problem hiding this comment.
Hysterical raisins? I'm not sure, it's always been like that. We do yield self.verify(...), I guess we could refactor it a bit, but I don't really want to change that as part of this PR.
ahal
force-pushed
the
ahal/push-wxrpmmuqqost
branch
from
32dcb76 to
d2a6625
Compare
jcristau
approved these changes
Aug 1, 2025
ahal
force-pushed
the
ahal/push-wxrpmmuqqost
branch
from
d2a6625 to
4ecf2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1980436