Skip to content

Be a lot more conservative in _github_submodule_required #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eijebong merged 1 commit into from
Jun 17, 2025
Merged

Be a lot more conservative in _github_submodule_required #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/taskgraph/run-task/fetch-content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,8 +679,15 @@ def _github_submodule_required(repo: str, commit: str):
try:
status_code = urllib.request.urlopen(url).getcode()
return status_code == 200
except:
return False
except urllib.error.HTTPError as e:
if e.status == 404:
return False
# If we get a non 2xx status code that isn't a 404, something has gone horribly wrong on the github side, log it and return True
log("Got {} from github while checking for submodules in {} which was unexpected. Cannot check whether the repo has submodules or not".format(e.status, repo))
return True
except Exception as e:
log("Got an unexpected `{}` exception while checking for submodules in {}. Cannot check whether the repo has submodules or not".format(e, repo))
return True


def git_checkout_archive(
Expand Down
Loading