Add a workflow to run auto updates for pre-commit #678
Conversation
This replaces the pre-commit.ci app's autoupdate. The one caveat with this is that it doesn't check for PRs that are already opened on that branch. I did that to keep it as simple as possible. It's not a real issue as github will detect that and close the previous PR and then open a new one but it might be a bit spammy if we don't merge those PRs
|
example of it working. I have this repo where I ran the job on push instead of cron. |
|
I somewhat think it wouldn't be much harder to do this as a Taskcluster cron, but also that it's not worth switching now |
The advantage of this is that we don't have to worry about the token as github provides it for us in the workflow. |
True! One trick we could use is that because |
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
I think it's something I have mentioned previously at a community meeting. We already have a way of creating comments through said app, it would be nice to expand on that capability |
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
2 participants
This replaces the pre-commit.ci app's autoupdate.
The one caveat with this is that it doesn't check for PRs that are already opened on that branch. I did that to keep it as simple as possible. It's not a real issue as github will detect that and close the previous PR and then open a new one but it might be a bit spammy if we don't merge those PRs