Run pre-commit in a github action #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
force-pushed
the
pre-commit-gha
branch
2 times, most recently
from
c4d7adb to
a8712c5
Compare
Eijebong
force-pushed
the
pre-commit-gha
branch
from
b30679a to
bba8a40
Compare
Eijebong
changed the title
bhearsum
approved these changes
Apr 10, 2025
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 14, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 14, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 16, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 16, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
ahal
pushed a commit
to mozilla-releng/mozilla-taskgraph
that referenced
this pull request
Apr 21, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.