Skip to content

Conversation

@jcristau
Copy link
Contributor

@jcristau jcristau commented Apr 2, 2025

The decision task knows the contents of these scripts so it can pass their checksums to downstream tasks.

@jcristau jcristau force-pushed the run-task-mount branch 2 times, most recently from d8e5a77 to f759627 Compare April 3, 2025 09:09
The decision task knows the contents of these scripts so it can pass
their checksums to downstream tasks.
@jcristau
Copy link
Contributor Author

jcristau commented Apr 3, 2025

AIUI this should work with generic-worker >= 10.8.0 (which included https://bugzilla.mozilla.org/show_bug.cgi?id=1459376)

@jcristau jcristau marked this pull request as ready for review April 3, 2025 09:56
@jcristau jcristau requested a review from ahal April 3, 2025 15:38
Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this slipped, lgtm!

@jcristau jcristau merged commit f85ff32 into taskcluster:main Apr 10, 2025
16 checks passed
@jcristau jcristau deleted the run-task-mount branch April 10, 2025 16:02
jcristau added a commit to jcristau/taskgraph that referenced this pull request May 13, 2025
Fixes a regression from taskcluster#666, which:
- used taskId instead of task-id in the task description
- failed to add sha256 to the schema
jcristau added a commit to jcristau/taskgraph that referenced this pull request May 13, 2025
Fixes a regression from taskcluster#666, which:
- used taskId instead of task-id in the task description
- failed to add sha256 to the schema
jcristau added a commit that referenced this pull request May 13, 2025
Fixes a regression from #666, which:
- used taskId instead of task-id in the task description
- failed to add sha256 to the schema
jcristau added a commit to jcristau/taskgraph that referenced this pull request May 13, 2025
…askcluster#666)"

This causes failures because not all tasks have a direct dependency on the
decision task, but generic-worker insists on that dependency existing
when mounting an artifact from a task.  So go back to mounting by url.

This reverts commit f85ff32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants