Skip to content

ci: add pre-commit check to keep uv.lock updated #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahal merged 4 commits into from
Feb 20, 2025
Merged

ci: add pre-commit check to keep uv.lock updated #650

ahal merged 4 commits into from
Feb 20, 2025

Conversation

@ahal
Copy link
Collaborator

@ahal ahal commented Feb 18, 2025

No description provided.

@ahal ahal requested a review from a team February 18, 2025 19:55
@ahal ahal self-assigned this Feb 18, 2025
@ahal ahal requested a review from Eijebong February 18, 2025 19:55
@ahal ahal marked this pull request as draft February 18, 2025 20:00
@ahal
Copy link
Collaborator Author

ahal commented Feb 18, 2025

So the pre-commit check is working fine.. but for some reason running uv lock is removing the version for "taskcluster-taskgraph", which presumably is causing this failure?

Not sure if this is a uv regression or if our CI isn't setup properly.

@Eijebong
Copy link
Contributor

Eijebong commented Feb 19, 2025

Updating uv should do the trick. I'm not entirely sure what the issue is but the fact that uv python install 3.13 installs a RC when there are 2 dot releases already is not great and most likely related.

image

@ahal ahal force-pushed the ahal/push-lvsokyknolto branch 2 times, most recently from 237dafb to 52019e7 Compare February 19, 2025 19:19
@ahal
Copy link
Collaborator Author

ahal commented Feb 19, 2025

Well that worked, but looks like it uncovered a latent issue in the decision image task.

@Eijebong
Copy link
Contributor

Eijebong commented Feb 20, 2025

First release of uv for which this error happens: https://github.com/astral-sh/uv/releases/tag/0.4.13

@ahal
Copy link
Collaborator Author

ahal commented Feb 20, 2025

Thanks confirmed. Specifically this commit:
https://github.com/astral-sh/uv/pull/7544/files

Looks like this might be a misconfiguration on our end that was previously failing silently, but is now loud.

@ahal ahal force-pushed the ahal/push-lvsokyknolto branch 2 times, most recently from d6758fb to 02b57a6 Compare February 20, 2025 17:39
ahal added 4 commits February 20, 2025 12:39
@ahal
ci: only pass 'UV_VERSION' to Dockerfiles that actually use it
e867758 
Otherwise it can cause some annoyance / confusion when building images
locally.
@ahal
fix(decision): remove misconfigured environment variable from Decisio…
fd54cb2 
…n image

This variable wasn't being used properly. Older versions of uv were
failing silently, but as of uv 0.4.13 this started causing an error.
@ahal
fix(decision): update uv to latest version in run-task/decision images
1e2f102
@ahal
ci: add pre-commit check to keep uv.lock updated
6dbcacc
@ahal ahal force-pushed the ahal/push-lvsokyknolto branch from 02b57a6 to 6dbcacc Compare February 20, 2025 17:39
@ahal ahal marked this pull request as ready for review February 20, 2025 18:39
@ahal ahal merged commit a2f5e8c into taskcluster:main Feb 20, 2025
21 checks passed
@ahal ahal deleted the ahal/push-lvsokyknolto branch February 20, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eijebong Eijebong Eijebong approved these changes

Assignees

@ahal ahal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahal @Eijebong