feat: port taskgraph action from gecko_taskgraph
#645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
force-pushed
the
taskgraph-actions
branch
from
0375acd to
688ca43
Compare
Eijebong
changed the title
taskgraph action from gecko_taskgraphtaskgraph action from gecko_taskgraph
Contributor
Author
|
Marking this back as a draft as after talking to @hneiva about it, I discovered that there were indeed a few tests in |
The documentation already says `You can generate actions.json locally by running taskgraph actions.` however that command was never ported over from gecko's `./mach taskgraph actions`
To be able to test without relying on actions that are always generated too much, I monkeypatch `registry._load` so it simply doesn't import the modules registering those actions. Adding that test found that parameters should be parsed with `strict=False` to match other CLI actions. The return value isn't strictly necessary but I added it to be consistent with other functions in the CLI.
Eijebong
force-pushed
the
taskgraph-actions
branch
from
688ca43 to
49ec488
Compare
Contributor
Author
|
Ah great, something is leaving the test env dirty.
|
Contributor
Author
|
Ah yeah, I see taskgraph/test/test_actions_registry.py Line 101 in 5200e65 The modules declaring the actions get imported, the actions registered. Later when the second test runs, it mocks the |
Otherwise a previous test might have imported the actions modules already, making `registry._load` a no-op and failing the test
ahal
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation already says
You can generate actions.json locally by running taskgraph actions.however that command was never ported over from gecko's./mach taskgraph actions