Skip to content

build-image: check exit code from docker build #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcristau merged 1 commit into from
Jan 31, 2025
Merged

build-image: check exit code from docker build #638

jcristau merged 1 commit into from
Jan 31, 2025

Conversation

@jcristau
Copy link
Contributor

@jcristau jcristau commented Jan 29, 2025 •
edited
Loading

Avoid saying Successfully built <image> when it wasn't.

@jcristau jcristau requested a review from ahal January 29, 2025 12:47
@jcristau jcristau marked this pull request as ready for review January 29, 2025 12:47
@jcristau jcristau merged commit d4e7559 into taskcluster:main Jan 31, 2025
16 checks passed
@jcristau jcristau deleted the image-build-check branch January 31, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eijebong Eijebong Eijebong approved these changes

@ahal ahal Awaiting requested review from ahal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcristau @Eijebong