fix: return tasks by task_id in get_ancestors to avoid collisions in labels #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labels BREAKING CHANGE: `get_ancestors` now returns a dict of task_id to label rather than label to task_id This allows it to give a complete list of ancestors in graphs that have multiple tasks with the same label.
jcristau
approved these changes
Jan 23, 2025
bhearsum
added
the
BREAKING CHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
get_ancestorsnow returns a dict of task_id to label rather than label to task_idThis allows it to give a complete list of ancestors in graphs that have multiple tasks with the same label.