docs: add to docker howto #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
approved these changes
Jan 22, 2025
Contributor
JohanLorenzo
left a comment
JohanLorenzo
left a comment
There was a problem hiding this comment.
Great! Thanks for documenting this taskgraph-ism 🙂
To future readers: an external contributor asked a question about DOCKER_IMAGE_PARENT to @jcristau and me. That's what uncovered this lack of documentation.
ahal
approved these changes
Jan 23, 2025
Collaborator
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks, this is clearly an improvement so r+.
I do have some suggestions to make it even more useful though :)
jcristau
force-pushed
the
docs-docker
branch
3 times, most recently
from
8461075 to
ed2eeab
Compare
Describe the `parent`, `definition` and `args` entries supported by the docker_image transforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the
parent,definitionandargsentries supported by the docker_image transforms.