Hash the uncompressed contents of docker context tar #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fourth argument is args, meant to be a dict.
With an increasing number of docker images, the overhead of hashing the compressed contents of the docker context tars becomes visible when loading the toolchain kind during Firefox builds. But the really interesting part for the hash is the uncompressed contents. Whether they are compressed with gzip at level 9, gzip level 1, bz2 or zstd, it doesn't matter for the resulting docker image. So it makes sense to only hash the uncompressed contents, which is much faster.
jcristau
approved these changes
Jan 15, 2025
jcristau
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an increasing number of docker images, the overhead of hashing the compressed contents of the docker context tars becomes visible when loading the toolchain kind during Firefox builds. But the really interesting part for the hash is the uncompressed contents. Whether they are compressed with gzip at level 9, gzip level 1, bz2 or zstd, it doesn't matter for the resulting docker image. So it makes sense to only hash the uncompressed contents, which is much faster.