Skip to content

fix: Add False as option in from-deps set-name config #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hneiva merged 1 commit into from
Jan 6, 2025
Merged

fix: Add False as option in from-deps set-name config #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/taskgraph/transforms/from_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
),
): Any(
None,
False,
*SET_NAME_MAP,
{Any(*SET_NAME_MAP): object},
),
Expand Down
21 changes: 21 additions & 0 deletions test/test_transforms_from_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ def assert_dont_set_name(tasks):
assert tasks[0]["name"] == "a-special-name"


def assert_dont_set_name_false(tasks):
handle_exception(tasks)
assert len(tasks) == 1
assert tasks[0]["name"] == "a-special-name"


def assert_set_name_strip_kind(tasks):
handle_exception(tasks)
assert len(tasks) == 2
Expand Down Expand Up @@ -187,6 +193,21 @@ def assert_group_by_all_with_fetch(tasks):
None,
id="dont_set_name",
),
pytest.param(
# task
{
"name": "a-special-name",
"from-deps": {
"group-by": "all",
"set-name": False,
},
},
# kind config
None,
# deps
None,
id="dont_set_name_false",
),
pytest.param(
# task
{
Expand Down
Loading