Bug 1526028 - Support opting into or out of specific caches in run transforms
#620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Dec 31, 2024
| if not task["run"].get("use-caches", True): | ||
| use_caches = task["run"].get("use-caches", True) | ||
| if isinstance(use_caches, list): | ||
| use_caches = any(re.match(r, name) for r in use_caches) |
Contributor
There was a problem hiding this comment.
Nit: rename r to pattern? Not a huge fan of single letter variable especially when they're so close to another one in the same scope (re). I don't have super strong opinions though so feel free to ignore.
ahal
force-pushed
the
push-rvmpmxqqwkkw
branch
from
3f7070c to
07ab89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.