Conversation
Contributor
martinzigrai
left a comment
martinzigrai
left a comment
There was a problem hiding this comment.
Looks good to me, but I left a few comments 🦘
| } | ||
|
|
||
| override fun onHostDestroy() { | ||
| backgroundHandlerThread.quitSafely() |
Contributor
There was a problem hiding this comment.
Suggested change
| ThreatDispatcher.unregisterListener() | |
| ExecutionStateDispatcher.unregisterListener() | |
| PluginThreatHandler.unregisterSDKListener(reactContext) | |
| backgroundHandlerThread.quitSafely() |
| import com.freeraspreactnative.utils.getStringThrowing | ||
| import com.freeraspreactnative.utils.toEncodedWritableArray | ||
|
|
||
| class FreeraspReactNativeModule(private val reactContext: ReactApplicationContext) : |
Contributor
There was a problem hiding this comment.
Does this change introduce a thread leak? Each module instance gets its own thread that is properly stopped in onHostDestroy(). Previously this was a static field, so quitSafely() in onHostDestroy() killed the thread permanently for the whole process. If the bridge restarted, the new module instance would still reference the same dead thread and any background work (e.g. malware icon encoding) would silently do nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Describe the PR shortly
PR checklist
In-app checks:
README.mdis updated (if applicable)expoplugin is updated (if applicable)exampleapp is workingPre-release checks:
CHANGELOG.mdis updatedpackage.jsonversion is increasedreleaselabel is applied on PRTo be checked by maintainers:
sdkVersionproperty in logs is correctsdkPlatformproperty in logs is correctResolved issues
list of issues resolved by this PR
resolves #143