Fix negation of theme() in arbitrary values#19928
Open
snaptopixel wants to merge 1 commit intotailwindlabs:v3from
Open
Fix negation of theme() in arbitrary values#19928snaptopixel wants to merge 1 commit intotailwindlabs:v3from
snaptopixel wants to merge 1 commit intotailwindlabs:v3from
Conversation
When using a negative modifier with theme() inside an arbitrary value (e.g. `-ms-[theme(margin.1)]`), no CSS was generated because `negateValue` did not recognize `theme()` as a negatable function. Added `theme` to the list of numeric functions in `negateValue` so that `theme()` values are wrapped in `calc(... * -1)` and then resolved by the PostCSS theme() plugin downstream.
Member
|
Edit: This is for Tailwind CSS v3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using a negative modifier with
theme()inside an arbitrary value produces no CSS output.ms-[theme(margin.1)]— works-ms-[10px]— works-ms-[theme(margin.1)]— no outputCause
negateValue()insrc/util/negateValue.jsdoesn't recognizetheme()as a negatable function. It falls through all conditions and returnsundefined, causing the utility to be silently dropped.Fix
Added
'theme'to thenumericFunctionslist sotheme()values get wrapped incalc(... * -1), which the PostCSStheme()resolver then processes downstream.Tests
negateValue.test.js):negateValue('theme(margin.1)')returnscalc(theme(margin.1) * -1)arbitrary-values.test.js):-mt-[theme(spacing.1)]producesmargin-top: -0.25rem