Merged
Conversation
nickkhyl
approved these changes
Feb 20, 2026
Contributor
nickkhyl
left a comment
nickkhyl
left a comment
There was a problem hiding this comment.
The name and the docstring on the modelName are confusing.
tailscale-android/libtailscale/tailscale.go
Lines 91 to 94 in 287c2aa
But the implementation does in fact what this PR says, and the naming/docstring are not new, so LGTM. But maybe s/modelName/deviceName/ here or in a follow-up?
barnstar
approved these changes
Feb 20, 2026
Use device name, with hardware model as a fallback for hostname in Android, since os.Hostname returns localhost Updates tailscale/tailscale#7875 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
force-pushed
the
kari/localhost
branch
from
8af1d04 to
6c094cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use device name, with hardware model as a fallback for hostname in Android, since os.Hostname returns localhost
Updates tailscale/tailscale#7875