support opening a connection with custom flags#126
Open
Conversation
oxtoacart
requested review from
knyar and
zofrex
and removed request for
zofrex
oxtoacart
force-pushed
the
percy/corp36592
branch
from
2ef08bc to
cb7bab3
Compare
knyar
reviewed
Feb 4, 2026
sqlite.go
Outdated
| // Connect implements [driver.Connector.Connect] | ||
| func (p *connector) Connect(ctx context.Context) (driver.Conn, error) { | ||
| db, err := Open(p.name, sqliteh.OpenFlagsDefault, "") | ||
| return p.ConnectFlags(ctx, sqliteh.OpenFlagsDefault) |
Contributor
There was a problem hiding this comment.
Did you mean to use the passed flags here instead of the default?
Suggested change
| return p.ConnectFlags(ctx, sqliteh.OpenFlagsDefault) | |
| return p.ConnectFlags(ctx, p.openFlags) |
This introduces the use of the options pattern with the new `ConnectorWithOpts` function. The opt `WithOpenFlags` allows specifying custom flags to use when opening connections. When left unspecified, we use the same `sqliteh.OpenFlagsDefault` as before. Updates tailscale/corp#36592 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/corp36592
branch
from
cb7bab3 to
74fb5f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
ConnectFlagssupports passing insqliteh.OpenFlagsto configure the connection.Connectstill usessqliteh.OpenFlagsDefault.Updates tailscale/corp#36592