Conversation
The type is already compatible directly out of the API so there's no need for the cast dance in these calls. Updates #cleanup
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary unsafe pointer casts from two SQLite column metadata functions. The SQLite C API already returns const char * (mapped to *C.char in cgo), making the intermediate unsafe.Pointer cast redundant.
- Simplified
ColumnDatabaseNameto directly pass the C function result toC.GoString - Simplified
ColumnTableNameto directly pass the C function result toC.GoString
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
creachadair
approved these changes
Jan 6, 2026
bradfitz
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type is already compatible directly out of the API so there's no need for the cast dance in these calls.
Updates #cleanup