Conversation
* Add a nixosModule * Add an overlay fixes tailscale-dev#63
| }: | ||
| { | ||
| overlays.default = final: prev: { | ||
| tclip = self.packages."${prev.system}".tclip; |
There was a problem hiding this comment.
If I look at other examples https://github.com/ryantm/agenix they are structured differently; t
the overlay defines the packages and then packages attribute just pull it out of nixpkgs itself.
This goes in the other direction; not sure how "wrong" that is.
There was a problem hiding this comment.
I don't have any strong feelings here, as long as it works well and doesn't break or complicate anything.
flake.nix
Outdated
| CGO_ENABLED = "0"; | ||
| }; | ||
|
|
||
| docker = pkgs.dockerTools.buildLayeredImage { |
There was a problem hiding this comment.
These changes are from formatting; I added formatter as an attribute so nix fmt should keep this consistent.
|
I would love if someone else can test this out too; I'll post on my twitter. |
|
@Erisa let me know what you think. The systemd service was failing to run because I gave it an invalid auth key. |
Erisa
left a comment
There was a problem hiding this comment.
Thank you for contributing this! Sorry for the delay getting around to reviewing this.
Are you able to
- Add support for all the options available here: https://github.com/tailscale-dev/tclip?tab=readme-ov-file#configuration
- Add some short documentation to the README on how one might use this? If there are general resources you can point to that explain concepts better, those can be linked to.
My experience with NixOS (especially with flakes) is a little lacking and while I was able to add this as an input for a flake, I had difficulty getting it to work in order to test. I imagine the README changes should help with that!
|
@Erisa I plan to revisit your comments; I've just been busy. For those who want to see a working version, I've been running in my NixOS configuration |
|
Thanks for the example - and no worries about being busy, I have been as well! |
This how I tested it:
nixos-rebuild build-vm --flake ".#test"Validation
fixes #63