cmd/tclipd: allow creating tokens to edit the contents of a note from a Internet node#43
Open
lucasew wants to merge 1 commit intotailscale-dev:mainfrom
Open
cmd/tclipd: allow creating tokens to edit the contents of a note from a Internet node#43lucasew wants to merge 1 commit intotailscale-dev:mainfrom
lucasew wants to merge 1 commit intotailscale-dev:mainfrom
Conversation
… a Internet node Signed-off-by: lucasew <lucas59356@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a opt-in feature that, to be enabled, one must pass a flag (
-use-set-tokens) or a environment variable (USE_SET_TOKENS) to enable.Basically it allows the owner of a note to create edit tokens. The flow is the following:
In practice:
go run -v ./cmd/tclipd -data-location /tmp/test-paste -hostname test-paste -tsnet-verbose -use-funnel -use-set-tokenshttps://test-paste.stargazer-shark.ts.net/api/token/set/0d4f1364-548f-4fdd-ba08-d5e1c3503044curl https://test-paste.stargazer-shark.ts.net/api/token/set/0d4f1364-548f-4fdd-ba08-d5e1c3503044 -d blahI also abstracted away some details like the function to assert that the request is in the form format to a function to reuse in other routes (before that this logic was only used once).
BTW I hope I got the CSS right lol.