fix: use interactive exec for custom command execution#3493
Open
amitksingh1490 wants to merge 2 commits into
Open
fix: use interactive exec for custom command execution#3493amitksingh1490 wants to merge 2 commits into
amitksingh1490 wants to merge 2 commits into
Conversation
Replace _forge_exec with _forge_exec_interactive in custom command dispatcher path to ensure custom commands get proper interactive terminal handling, consistent with the default agent execution path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix custom command execution to use interactive exec, ensuring proper terminal handling when running custom commands through the shell plugin.
Context
When executing custom commands via the shell plugin's dispatcher (
:commandsyntax), the_forge_execfunction was being used instead of_forge_exec_interactive. This meant custom commands were missing interactive terminal capabilities (like proper pty handling, signal forwarding, and real-time output streaming) that are already present for default agent execution atdispatcher.zsh:82.Changes
_forge_execcalls with_forge_exec_interactivein the custom command branch of_forge_action_defaultKey Implementation Details
The
_forge_exec_interactivefunction provides a proper interactive terminal session with pty support, while_forge_execis a simpler non-interactive execution. Custom commands benefit from the same interactive capabilities as the default agent path, which already uses_forge_exec_interactive.Testing