Skip to content

update main dependencies#38

Open
hoodie wants to merge 1 commit into
tafia:masterfrom
hoodie:feature/update-dependencies
Open

update main dependencies#38
hoodie wants to merge 1 commit into
tafia:masterfrom
hoodie:feature/update-dependencies

Conversation

@hoodie

@hoodie hoodie commented Jul 21, 2023

Copy link
Copy Markdown

Hi there,
I've noticed that some deps are out of date and thought I'd give it a try.

What do you think?

@hoodie hoodie force-pushed the feature/update-dependencies branch from 1d5720d to 49325f3 Compare July 21, 2023 19:24
Comment thread Cargo.toml

webpki = { version = "0.21", optional = true }
rustls-native-certs = { version = "0.5.0", optional = true }
webpki-roots = { version = "0.21.0", optional = true }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope to see this MR merged soon. Currently facing https://rustsec.org/advisories/RUSTSEC-2023-0052 from this.

@jselig-rigetti

Copy link
Copy Markdown

Looks like this should supersede #28, #30, and #31

@hoodie

hoodie commented Nov 17, 2023

Copy link
Copy Markdown
Author

ping @tafia

@jselig-rigetti

Copy link
Copy Markdown

@tafia please consider this change.

@hoodie

hoodie commented Apr 12, 2024

Copy link
Copy Markdown
Author

@jselig-rigetti I think for your usecase you should probably look at http-proxy2. I just found that when I published my changes to https://github.com/goto-opensource/hyper-proxy 🙄 😆

@jselig-rigetti

Copy link
Copy Markdown

@jselig-rigetti I think for your usecase you should probably look at http-proxy2. I just found that when I published my changes to https://github.com/goto-opensource/hyper-proxy 🙄 😆

I'd looked at it, but it has an http = "1.0" dependency which conflicts with tonic since it depends on http = "0.2" so I ended up forking this repo. Thank you though!

@hoodie

hoodie commented Apr 14, 2024

Copy link
Copy Markdown
Author

oh boy, there are a bunch of forks of this now 😆
I was about to publish my version as hyper-proxy2 until I saw that other one. And naming things is sooo hard.

@wyatt-herkamp

Copy link
Copy Markdown

oh boy, there are a bunch of forks of this now 😆 I was about to publish my version as hyper-proxy2 until I saw that other one. And naming things is sooo hard.

About to do the same.

@hoodie

hoodie commented Apr 15, 2024

Copy link
Copy Markdown
Author

@wyatt-herkamp feel free to pull from my fork

@aviramha

aviramha commented May 13, 2024

Copy link
Copy Markdown

@hoodie did you end up publishing? (your fork looks the most mature)

@hoodie

hoodie commented May 19, 2024

Copy link
Copy Markdown
Author

No because there already is hyper-proxy2

@aviramha

Copy link
Copy Markdown

We had some issues with hyper-proxy2, also some that would do breaking changes - we created https://github.com/metalbear-co/hyper-http-proxy which is also published to crates.
We removed openssl support (just because it took time to adjust the fixes and we didn't care about it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants