MOB-5807 Added Interstitial screen#12
Conversation
sanjacurcic-taboola
requested review from
tomer-br-taboola and
voltfmanSlava
Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/InterstitialFragment.java
Show resolved
Hide resolved
Java/app/build.gradle
Outdated
|
|
||
| //Taboola | ||
| implementation 'com.taboola:android-sdk:4.0.22' | ||
| implementation 'com.taboola:android-sdk-beta:4.0.24-rc1-502-a83c67def' //TODO: Change to the official SDK 4 version when it's ready. |
There was a problem hiding this comment.
@sanjacurcic-taboola make sure to change this to the official version and not beta
Kotlin/app/src/main/java/com/taboola/kotlin/examples/screens/classic/InterstitialFragment.kt
Show resolved
Hide resolved
Kotlin/app/build.gradle
Outdated
| dependencies { | ||
| // Import Taboola SDK | ||
| implementation 'com.taboola:android-sdk:4.0.22' | ||
| implementation 'com.taboola:android-sdk-beta:4.0.24-rc1-502-a83c67def' //TODO: Change to the official SDK 4 version when it's ready. |
There was a problem hiding this comment.
@sanjacurcic-taboola don't forget to update this version to the official once it released.
sanjacurcic-taboola
force-pushed
the
feature/MOB-5807-interstitial-screen
branch
from
3bebb53 to
bf268c2
Compare
Java/app/src/main/java/com/taboola/sdk4example/sdk_classic/InterstitialFragment.java
Outdated
Show resolved
Hide resolved
Kotlin/app/src/main/java/com/taboola/kotlin/examples/screens/classic/InterstitialFragment.kt
Outdated
Show resolved
Hide resolved
Kotlin/app/src/main/java/com/taboola/kotlin/examples/screens/classic/InterstitialFragment.kt
Outdated
Show resolved
Hide resolved
|
@sanjacurcic-taboola - Should we add a compose example for Interstitial? |
|
@tomer-br-taboola Added Interstitial Compose screen. |
|
@sanjacurcic-taboola - It's great that you added a Compose screen for Interstitial. I wanted to ask if you synced on this with @SasaJov and made sure he has a SwiftUI equivalent? |
I haven't talked to Sasa about this yet since he is on vacation. I'll update him when he gets back. |
.../main/java/com/taboola/kotlin/examples/screens/classic/ClassicInterstitialComposeFragment.kt
Show resolved
Hide resolved
|
@sanjacurcic-taboola - I am approving with a comment. |
tomer-br-taboola
left a comment
tomer-br-taboola
left a comment
There was a problem hiding this comment.
Approving with a comment.
3 participants
Edit: Added the Interstitial Compose screen to the Kolin project.
Interstitial screens have been implemented in Java and Kotlin projects.
Java project:
Kotlin project:
Compose screen: