Docs fix & scripts update proposal for NixOS #8342
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated NixOS installation requirements to include additional configuration settings.
Updated NixOS requirements to include envfs and nix-ld settings.
Since bash does not always is in `/bin/bash`, or sometimes the path might not even exist (i.e. on NixOS without `services.envfs.enabled = true;`) - it might be safer and a better practice in general to change shebangs of generated scripts to /usr/bin/env bash (and maybe do the same thing for python scripts shebangs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
The local deployment process is flaky on NixOS, since the bazel code, generating the scripts for the bootstrap sets shebangs to paths that may be nonexistent on the system.
The easiest fix would be to just add the relevant info for the users in the docs.
Second approach would be to fix the shebangs in the generated scripts (example in
prelude-si/toolchains/extraction.bzl; although there should be also a change made in a bazel file generating the python-wrapper and the healthcheck - I wasn't able to dig those two out)The third possible fix that might be investigated although would take significantly more engineering effort would be to have nix do the toolchain retrieval and extraction, although I did not investigate that angle if there are any major blockers in implementing that.
Does it require a docs change?