kbscan: Increase debounce time from 10ms to 20ms#433
kbscan: Increase debounce time from 10ms to 20ms#433uSpike wants to merge 1 commit intosystem76:masterfrom
Conversation
I found that a debounce time of 10ms was causing very frequent twice-registered keys with my typing style. After setting the debounce time to 20ms I find that no repeated characters occur when typing 10 line of text. Ref: system76/firmware-open#509 Signed-off-by: Jordan Speicher <jordan@jspeicher.com>
leviport
left a comment
leviport
left a comment
There was a problem hiding this comment.
This seems like it's working fine for me.
|
Any chance this could be merged? I've not upgraded EC for some time waiting for this.. |
|
Just want to point out that this value was originally set to 20ms. It was reduced to 15ms alongside other behavior improvements: #60 After that, anther user wanted it moved all the way down to 3ms: #359 As a compromise, we went to 5ms (#378), but later raised it back up to the current 10ms (#405). I wonder if this config needs to be more board-specific (if the ghosting behavior differs per laptop), or if it should just be more user-configurable without having to build custom firmware, since there's been so much push and pull on different values. It's possible the behavior improvements in #60 would've made it work alright without changing the value at that time, but it's also possible another user comes along wanting another timing change after this is merged. |
3 participants
I found that a debounce time of 10ms was causing very frequent twice-registered keys with my typing style. After setting the debounce time to 20ms I find that no repeated characters occur when typing 10 line of text.
Fixes: system76/firmware-open#509