port to libyang 4 sysrepo 4 #92
Merged
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the new major versions of libyang.so and libsysrepo.so. Modify cffi/cdefs.h file according to sysrepo modifications: - Remove sr_conn_flag_t enum values, sr_connect does not use the flags anymore. Add the context flag instead. - Add sr_cache_running and sr_context_options. Adapt SysrepoConnection init to use the new syrepo functions: sr_cache_running and sr_context_options. Allow only libsysrepo.so.8 only. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
Add the possibility to add the no_printed flag when creating the sysrepo session to avoid loading the context from the shared memory. Apply it by default to keep the behavior as before. The printed context is valuable to get a the sysrepo config/state faster but some operations on the context itself do not work. For instance printing and parsing a yang model will fail. Link: https://github.com/sysrepo/sysrepo/blob/v4.2.10/README.md#printed-context Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
===========================================
+ Coverage 66.93% 82.93% +16.00%
===========================================
Files 8 8
Lines 1113 1137 +24
===========================================
+ Hits 745 943 +198
+ Misses 368 194 -174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
CESNET/libyang-python#160