Mark constants early to enable SCCP#316
Draft
Qchan233 wants to merge 1 commit intosysprog21:masterfrom
Draft
Conversation
jserv
reviewed
Dec 26, 2025
Comment on lines
+33
to
+35
| if (insn->opcode == OP_load_constant) { | ||
| insn->rd->is_const = true; | ||
| } |
Collaborator
There was a problem hiding this comment.
Make it slightly shorter. That is,
if (insn->opcode == OP_load_constant)
insn->rd->is_const = true;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging, I found that the sccp optimization doesn't work using the following example, though constant folding does the work. I think it would be good that gets optimized early in sccp.
Summary by cubic
Mark destinations of OP_load_constant as const in SCCP. This enables early constant propagation so SCCP optimizes trivial branches and assignments (e.g., returning a constant after an if/else).
Written for commit 483a46a. Summary will update automatically on new commits.