Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the project from Go 1.24 to Go 1.26, leveraging new language features and updating dependencies. The update introduces support for the new go fix tool and adopts Go 1.26's enhanced new() syntax that appears to accept value expressions directly, eliminating the need for custom pointer helper functions.
Changes:
- Upgraded Go toolchain from 1.24 to 1.26 across build configurations
- Replaced custom
toPtr/asPtrhelper functions with Go 1.26'snew(value)syntax throughout the codebase - Added
go fixcommand integration to the build pipeline and pre-commit hooks - Updated dependencies (mcp-go, ginkgo, gomega, golang.org/x packages) and base Docker images
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.nix | Updated to use buildGo126Module and refreshed vendorHash for new dependencies |
| go.mod | Updated Go version to 1.26.0 and bumped dependency versions |
| go.sum | Updated checksums for new dependency versions |
| flake.nix | Updated to use go_1_26 in dev environment and removed old go override |
| flake.lock | Updated nixpkgs to newer revision |
| justfile | Added fix command using go fix ./... and integrated it into check pipeline |
| .pre-commit-config.yaml | Added pre-commit hook for go fix |
| .golangci.yml | Created linter config disabling SA4006/SA4017 for Go 1.26 new() syntax compatibility |
| docker-base-*.nix | Updated base image digests and hashes |
| internal/infra/mcp/tools/utils.go | Removed custom toPtr helper function |
| internal/infra/mcp/tools/tool_list_runtime_events.go | Migrated from toPtr() to new() syntax |
| internal/infra/mcp/tools/*_test.go | Migrated from toPtr()/asPtr() to new() syntax in test files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fixtool to automatically modernize code to newer versions.