Ability to run e2e build beyond local #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to configure E2E (end-to-end) test builds to use network-based Electrum backends and different Bitcoin networks (mainnet, testnet, signet, regtest) instead of being limited to local backends only. This provides more flexibility for running E2E tests in different environments.
Key changes:
- Added
E2E_BACKENDandE2E_NETWORKInfo.plist keys that can be set via environment variables at build time - Implemented logic in
Env.swiftto read these configuration values and apply them to network and Electrum server selection - Updated documentation to explain how to use the new build-time configuration options
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Added documentation examples showing how to set E2E_BACKEND and E2E_NETWORK environment variables for different test scenarios |
| AGENTS.md | Updated build instructions to include the new E2E configuration options with network backend example |
| Bitkit/Info.plist | Added E2E_BACKEND and E2E_NETWORK keys for runtime configuration via build-time environment variable substitution |
| Bitkit/Constants/Env.swift | Added infoPlistValue helper, e2eBackend and e2eNetwork properties, refactored network selection logic to support configurable E2E networks, and updated electrumServerUrl to conditionally use local backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Counterpart of synonymdev/bitkit-android#563
Linked Issues/Tasks
Screenshot / Video
Insert relevant screenshot / recording