fix: settle invalid migration transfers from unpaid orders#813
Open
jvsena42 wants to merge 4 commits intofix/channel-close-uifrom
Open
fix: settle invalid migration transfers from unpaid orders#813jvsena42 wants to merge 4 commits intofix/channel-close-uifrom
jvsena42 wants to merge 4 commits intofix/channel-close-uifrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of synonymdev/bitkit-ios#466
This PR:
createTransfersForPaidOrdersto only create transfers for orders in PAID state, skipping expired/executed/refunded ordersclientBalanceSatinstead ofclientBalanceSat + feeSatsyncTransferStatesDescription
When migrating from the RN version of Bitkit, the backup's
paidOrdersmap can contain orders that were never actually paid (expired, refunded, etc). This caused invalid transfers to be created, leaving stuck phantom transfers in the user's wallet.The fix applies a three-layer defense:
Preview
unpaid-order-import-bug.webm
after-fix.webm
QA Notes
blocktank.tswith this file blocktank.ts to create an order without broadcast the paymentcheckForAppUpdate();to don't display the update sheetmasterbranchfix/unpaid-order-import