feat: save app and ldk logs to same file #713
Open
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
ovitrif
changed the title
This comment has been minimized.
This comment has been minimized.
ovitrif
changed the title
ovitrif
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
ovitrif
force-pushed
the
claude/issue-655-20260122-1114
branch
2 times, most recently
from
ed51c18 to
bfa9a1f
Compare
- Both APP and LDK loggers now write to same file (bitkit_<timestamp>.log) - Logs are automatically in chronological order due to shared file - File writes serialized via single-threaded coroutine queue - APP/LDK tag prefixes distinguish log sources
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ovitrif
force-pushed
the
claude/issue-655-20260122-1114
branch
from
b4989ce to
778ca10
Compare
jvsena42
reviewed
Jan 23, 2026
|
|
||
| val Logger = AppLogger() | ||
|
|
||
| class AppLogger(private val source: LogSource = LogSource.Bitkit) { |
Member
There was a problem hiding this comment.
nit: this source parameter is not used anymore
jvsena42
reviewed
Jan 23, 2026
Collaborator
Author
|
@claude address review points of jvsena |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
jvsena42
reviewed
Jan 23, 2026
| private const val TAG = "Logger" | ||
| private var saver: LogSaver? = null | ||
|
|
||
| fun getOrCreateSaver(): LogSaver { |
Member
There was a problem hiding this comment.
I see this method is called by two classes on init(). could have a race condittion
Member
There was a problem hiding this comment.
but as far as I can see, it would just replace the instance. WDYT?
jvsena42
reviewed
Jan 23, 2026
Member
There was a problem hiding this comment.
nit: Ldk LogSource is not used anymore, could be removed
jvsena42
reviewed
Jan 23, 2026
Comment on lines
61
to
66
| fun reset() { | ||
| warn("Wiping entire logs directory…", context = TAG) | ||
| runCatching { Env.logDir.deleteRecursively() } | ||
| saver = null | ||
| delegate = runCatching { createDelegate() }.getOrNull() | ||
| } |
Member
There was a problem hiding this comment.
on app wipe, reset() could race with getOrCreateSaver()
jvsena42
requested changes
Jan 23, 2026
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Worth take a look on the race condition comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
Summary
Both APP and LDK logs now write to the same file in chronological order.
Changes
bitkit_<timestamp>.logPreview
Testing
Or, as a dev just go to device explorer and the app's data folder and open that file in Android Studio to check.