fix: calculator preview keyboard overlap #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
… into fix/calculator-preview-keyboard
ovitrif
reviewed
Jan 22, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Added 2 nits. Claude still can't understand correctly the true intent of the 2 rules about modifiers and especially that one trying to enforce passing modifier as the last argument to functions, in an attempt of trying to avoid this from getting merged unnoticed during reviews.
app/src/main/java/to/bitkit/ui/screens/widgets/calculator/CalculatorPreviewScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/widgets/calculator/components/CalculatorInput.kt
Outdated
Show resolved
Hide resolved
Collaborator
|
@claude address the review comments in a new branch on the tip of this one, named like this one but with '-fix' suffix. Also reword the rule about passing modifier as the last argument without trailing comma in an attempt to better enforce that rule. |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
@claude I approve the pending commands on your last comment. Pls create the branch as prepared to be a PR targeting this one. |
This comment has been minimized.
This comment has been minimized.
… into fix/calculator-preview-keyboard # Conflicts: # app/src/main/java/to/bitkit/ui/screens/widgets/calculator/CalculatorPreviewScreen.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #692
This PR fixes the keyboard overlapping the input field in the Calculator widget preview screen.
Description
ScreenColumnwith the.screen()modifier for more flexible inset handlingkeyboardAsState()imePadding()to keep the buttons above the keyboardCalculatorInputto useOutlinedTextFielddirectly for better keyboard interactionPreview
Screen_recording_20260122_115904.webm
QA Notes