fix: sync exception not caught causing app crash #657
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652
This PR fixes the "Bitkit keeps stopping" crash that occurs after wallet restoration when LDK's transaction sync encounters an unconfirmed channel funding transaction on Electrum.
Description
LightningRepo.sync()usingrunCatchingto catch and propagate sync failuresWalletViewModelwhen sync timeout occurs instead of silently ignoring itThe root cause was that after wallet restoration, LDK couldn't find a channel's funding transaction on Electrum, causing an infinite retry loop until timeout. The exception was not properly handled, leaving the app appearing frozen and eventually triggering a crash.
Preview
QA Notes
1. Verify sync error handling
2. Verify normal sync still works
3. Regression tests