Skip to content

Fixed the paths of the Monolog config files #9621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz wants to merge 2 commits into from
Closed

Fixed the paths of the Monolog config files #9621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32af341
Fixed the paths of the Monolog config files
javiereguiluz Apr 18, 2018
d9bd634
Update the paths for the XML and PHP formats too
javiereguiluz Apr 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ to write logs using the :phpfunction:`syslog` function:

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
Copy link
Member

@xabbuh xabbuh Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other formats below?

Copy link
Member Author

@javiereguiluz javiereguiluz Apr 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Now we need to make a decision about this: keep using prod for the reasons I gave in #9621 (comment) or change it to dev for the reasons given by Hamza in #9621 (comment)

Copy link
Member

@xabbuh xabbuh Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add them to the dev file I think. It could be too confusing if you do not see all logs anymore during development. But maybe we should add a warning?

monolog:
handlers:
# this "file_log" key could be anything
Expand Down Expand Up @@ -150,7 +150,7 @@ one of the messages reaches an ``action_level``. Take this example:

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
handlers:
filter_for_errors:
Expand Down Expand Up @@ -264,7 +264,7 @@ option of your handler to ``rotating_file``:

.. code-block:: yaml

# config/packages/dev/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
handlers:
main:
Expand Down
4 changes: 2 additions & 2 deletions logging/channels_handlers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ from the ``security`` channel:

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
handlers:
security:
Expand Down Expand Up @@ -137,7 +137,7 @@ You can also configure additional channels without the need to tag your services

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
channels: ['foo', 'bar']

Expand Down
2 changes: 1 addition & 1 deletion logging/processors.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Finally, set the formatter to be used on whatever handler you want:

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
handlers:
main:
Expand Down
2 changes: 1 addition & 1 deletion reference/configuration/monolog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Full Default Configuration

.. code-block:: yaml

# config/packages/monolog.yaml
# config/packages/prod/monolog.yaml
monolog:
handlers:

Expand Down