Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 9, 2020

@Nyholm
Copy link
Member Author

Nyholm commented Oct 9, 2020

I updated the PR. I placed this section under "Cache Directory" now because $this->getCacheDir() is the default value and we refer to the read-write cache.

@javiereguiluz
Copy link
Member

Very nice contribution! Thanks Tobias.

@Nyholm
Copy link
Member Author

Nyholm commented Oct 9, 2020

Thank you. @noniagriconomie's reviews helped a lot =)

@javiereguiluz javiereguiluz merged commit 550dc8a into symfony:5.x Oct 9, 2020
@javiereguiluz javiereguiluz added this to the 5.2 milestone Oct 9, 2020
@noniagriconomie
Copy link
Contributor

@Nyholm it is much better imho, thx for taking into account my pov :)

@Nyholm Nyholm deleted the build-dir branch October 9, 2020 12:15
@mnapoli
Copy link
Contributor

mnapoli commented Oct 9, 2020

Thanks @Nyholm for all these docs PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HttpKernel] Add $kernel->getBuildDir() to separate it from the cache…

4 participants